add input file tail #645
Open
add input file tail #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jem Davies <jemsot@gmail.com>
Signed-off-by: Jem Davies <jemsot@gmail.com>
jem-davies
commented
Jan 9, 2026
jem-davies
commented
Jan 12, 2026
Signed-off-by: Jem Davies <jemsot@gmail.com>
Signed-off-by: Jem Davies <jemsot@gmail.com>
Replace errChan draining with doneChan synchronization to ensure watch() goroutine exits before closing file handle. Also fix file handle leaks in newTail() error paths.
jem-davies
force-pushed
the
add-input-file-tail
branch
from
ed975dc to
bbd8915
Compare
Signed-off-by: Jem Davies <jemsot@gmail.com>
gregfurman
reviewed
Jan 28, 2026
|
|
||
| if !os.SameFile(t.fileInfo, tempInfo) { | ||
| if t.logger != nil { | ||
| t.logger.Info(fmt.Sprintf("Handling rotation for %v", t.path)) |
Collaborator
There was a problem hiding this comment.
Can we downgrade these rotation logs to the debug level?
|
|
||
| pos, err := t.file.Seek(0, io.SeekCurrent) | ||
| if err != nil { | ||
| return fmt.Errorf("seek file: %w", err) |
Collaborator
There was a problem hiding this comment.
Perhaps some of these errors should have more info added:
Suggested change
| return fmt.Errorf("seek file: %w", err) | |
| return fmt.Errorf("failed to set seek on %s: %w", t.file.Name(). , err) |
Comment on lines
+291
to
+292
| line, err := t.reader.ReadBytes('\n') | ||
| line = bytes.TrimRight(line, "\r\n") |
Collaborator
There was a problem hiding this comment.
Any particular reason why we're exclusively using \n as a delimiter here?
Collaborator
Author
There was a problem hiding this comment.
Yes could have a config option for that
Comment on lines
+188
to
+189
| file *os.File | ||
| fileInfo os.FileInfo |
Collaborator
There was a problem hiding this comment.
Thoughts on using the *service.FS from the mgr *service.Resources instead for file reading?
i.e
mgr.FS().OpenFile()This way we're relying on our FS fixtures instead of the os package
gregfurman
reviewed
Jan 28, 2026
| } | ||
| } | ||
|
|
||
| func (fti *FileTailInput) Close(ctx context.Context) error { |
Collaborator
There was a problem hiding this comment.
Is this idempotent? Also, we should probably select on the ctx.Done() to allow returning early if the ctx is cancelled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some context: I had decided to implement this as a simpler alternative to #514.